disable tq info caching in task queue test#726
Merged
Conversation
cretz
approved these changes
Dec 9, 2024
josh-berry
reviewed
Jan 6, 2025
josh-berry
left a comment
josh-berry
left a comment
There was a problem hiding this comment.
@carlydf Do you plan to merge this soon? Would like to take it in the next release if it's ready.
cretz
reviewed
Jan 8, 2025
Comment on lines
+219
to
+221
| // this is overridden since we don't want caching to be enabled while testing DescribeTaskQueue | ||
| // behaviour related to versioning | ||
| "matching.TaskQueueInfoByBuildIdTTL": 0 * time.Second, |
Contributor
There was a problem hiding this comment.
So we disable search attribute caching for all users of the dev server, not just our test suite. I wonder if we should do that here too. Though it may give the dev server users unreasonable expectations about eventual consistency for task queue info.
Contributor
Author
There was a problem hiding this comment.
I think it's reasonable for the dev server to have the caching for now -- can always change it later, but I think this caching mechanism may change in the future as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: